Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin loosening requirements #22

Merged
merged 13 commits into from
Oct 22, 2021
Merged

Begin loosening requirements #22

merged 13 commits into from
Oct 22, 2021

Conversation

j6k4m8
Copy link
Member

@j6k4m8 j6k4m8 commented Oct 11, 2021

Fixes #21

@j6k4m8
Copy link
Member Author

j6k4m8 commented Oct 11, 2021

@AbdealiJK for your awareness, I'm working on #21 here! Feedback welcome.

@AbdealiLoKo
Copy link

AbdealiLoKo commented Oct 12, 2021

Just a thought - while doing changes to the GitHub workflow, you may also want to add black for code formatting to keep the syntax styles consistent

Also, in pypi I saw manylinux wheels. But I wasn't clear on why that is the case. Cause grand seems to be a pure python package ... And so, it should not be dependent on OS right ?

EDIT: Ignore my above statement on manylinux. I checked grand instead of grand-graph by mistake. For grand-graph, it may be good to add bdist_wheel and upload wheels directly to pypi as they are being standardized

@j6k4m8
Copy link
Member Author

j6k4m8 commented Oct 12, 2021

Just a thought - while doing changes to the GitHub workflow, you may also want to add black for code formatting to keep the syntax styles consistent

Yes! Probably going to do this in a separate PR so that the inevitable code changes don't get mixed in with the import sorting in this PR.

it may be good to add bdist_wheel and upload wheels directly to pypi as they are being standardized

Agreed!

@j6k4m8 j6k4m8 marked this pull request as ready for review October 22, 2021 15:32
@j6k4m8 j6k4m8 merged commit 6174faa into master Oct 22, 2021
@j6k4m8 j6k4m8 deleted the loosen-requirements branch October 22, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tightly pinned versions in requirements
2 participants